Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jenkinsci/git-client-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: git-client-6.4.2
Choose a base ref
...
head repository: jenkinsci/git-client-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: git-client-6.4.3
Choose a head ref
  • 6 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 16, 2025

  1. Configuration menu
    Copy the full SHA
    c610e60 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2025

  1. Return to executing scripts from workspace temp directory

    Fixes #1711
    
    Simplifying the code is not as valuable as retaining compatibility.
    MarkEWaite committed Dec 17, 2025
    2 Configuration menu
    Copy the full SHA
    04bf4fd View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2025

  1. Remove dead code from tempfile path sanitizer (#1714)

    Compute the absolute path once, then use the string repeatedly for the comparisons.
    MarkEWaite authored Dec 18, 2025
    Configuration menu
    Copy the full SHA
    8873cd0 View commit details
    Browse the repository at this point in the history
  2. Do not use paths with '%' for SSH temporary files (#1712)

    SSH has special rules related to '%' characters in its file name
    arguments.  Refer to the ssh_config man page for its descriptions
    of tokens:
    
    https://man.openbsd.org/ssh_config#TOKENS
    
    If the absolute path to the temporary file for the private key includes a
    '%' character, then use the system temporary directory instead.
    
    Likewise if the absolute path to the Windows temporary file for
    the private key includes a ' ', a '(', or a ')', then use the system
    temporary directory.
    
    Makes the createTempFile() implementation match the comment.
    
    Testing done:
    
    * Confirmed that I can duplicate the bug with a multibranch
      Pipeline cloned through an SSH URL when one of the branches in
      the repository contains a '/' character.  In my test case, I used
      'bug/git-cleint-plugin-1710' as the branch name
    * Confirmed that the bug is resolved by this change
    
    Pipeline definition used for test:
    
    pipeline {
        agent {
            label 'windows'
        }
        options {
            skipDefaultCheckout true
        }
        stages {
            stage('Checkout') {
                steps {
                    ws('percent%2Fencoded') {
                        checkout scm
                    }
                    ws('a b') {
                        checkout scm
                    }
                    ws('c(') {
                        checkout scm
                    }
                    ws('d)') {
                        checkout scm
                    }
                    ws('e())') {
                        checkout scm
                    }
                    ws('f g') {
                        checkout scm
                    }
                }
            }
        }
    }
    MarkEWaite authored Dec 18, 2025
    Configuration menu
    Copy the full SHA
    3b5f67d View commit details
    Browse the repository at this point in the history
  3. Correct merge error

    MarkEWaite committed Dec 18, 2025
    Configuration menu
    Copy the full SHA
    2bc9d6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99ac541 View commit details
    Browse the repository at this point in the history
Loading