Skip to content

Force jenkins user on exec commands#160

Open
diorcety wants to merge 1 commit intojenkinsci:masterfrom
diorcety:exec
Open

Force jenkins user on exec commands#160
diorcety wants to merge 1 commit intojenkinsci:masterfrom
diorcety:exec

Conversation

@diorcety
Copy link
Copy Markdown

@diorcety diorcety commented Dec 14, 2018 •
edited
Loading

replace #130
Allow to specify an different user for the run

docker.image('dummy').inside('-u root:root -e BUILDER_UID=1001 -e BUILDER_GID=1001 -e BUILDER_USER=jenkins -e BUILDER_GROUP=jenkins -e HOME=/home/jenkins) {
}

Will run
docker run -t -u 1001:1001 -u root:root ...
and
docker exec -u 1001:1001 ...

@diorcety diorcety force-pushed the exec branch 2 times, most recently from 4bd30db to da4a1b0 Compare January 9, 2019 17:36
@andrewnicols
Copy link
Copy Markdown

andrewnicols commented Feb 27, 2019

How can this be used with DSL?
At the moment we do something like:

agent {
    label 'docker'
    image 'php:7.1'
}

Obviously we can specify extra args, but will these allow overriding the user in the run stage?

I guess one 'ideal' would be to take a user argument in the agent stanza.

@diorcety diorcety mentioned this pull request Feb 27, 2019
Closed
@diorcety diorcety force-pushed the exec branch 4 times, most recently from 58d8c8a to bc59e1a Compare April 16, 2019 09:46
@diorcety diorcety force-pushed the exec branch 2 times, most recently from b75282f to d43a093 Compare October 22, 2019 08:04
@diorcety
Copy link
Copy Markdown
Author

diorcety commented Oct 22, 2019

I rebased my PR on master

@diorcety diorcety mentioned this pull request May 20, 2021
Open
@romanek-adam
Copy link
Copy Markdown

romanek-adam commented May 20, 2021

Does this change break any existing usage? If so then it should be implemented conditionally, based on a new parameter etc.

@diorcety
Copy link
Copy Markdown
Author

diorcety commented May 20, 2021 •
edited
Loading

This is break only the usage when the user force the user as image parameters with -u root:root for example. The current behaviour seems to be an issue for many people currently

@diorcety diorcety force-pushed the exec branch 3 times, most recently from 39963ee to 33cb834 Compare May 27, 2021 12:56
@diorcety diorcety force-pushed the exec branch 2 times, most recently from 1ec100b to be15d7c Compare May 28, 2021 13:14
@diorcety
Copy link
Copy Markdown
Author

diorcety commented May 28, 2021

Okay, I finally succeeded to test the behaviour.

@diorcety diorcety changed the title Set --user on exec, not on main run command Force jenkins user on exec commands May 31, 2021
@diorcety diorcety force-pushed the exec branch 2 times, most recently from 9b33ba2 to 897d4c7 Compare June 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@diorcety @andrewnicols @romanek-adam @ndeloof