Fix URL on images - #34
Conversation
When display a project,, icons before Job, All bilds, Locked builds, All
workspaces, Slave workspaces, Non-slave workspaces have a broken link.
The root URL was missing, add ${resURL} as prefix in the attribute src,
for node img.
|
How a change on image URL can failed to build. |
|
@ejouvin test can be unreliable, retriggered pr, let's look. |
|
Looks like this bad test also failed other PRs |
|
I applied the SNAPSHOT build for this and it works fine when using /jenkins/ as the prefix on my installation. |
|
@lvotypko highlight |
|
FYI, there is a Jira bug report that this PR fixes: JENKINS-30830 |
|
in what version this was fixed? i have 0.28 and i still have broken images on job details page because the urls are absoulte from site root. my jenkins installation is prefixed with accesses: https://jenkins.example.org/plugin/disk-usage/icons/directory16.png - 404 also in ticketing system there are still two tickets about same problem still open: |
|
@glensc This isn't in the 0.28 release. There wasn't a release yet after this was fixed. |
|
oh. but what's holding the release? |
|
Ok, I ran into this issue during install of Jenkins 2.5. Had to pull/clone and build locally myself to get 0.29-snapshot. Why on earth has this not been released yet? |
|
I also has this icon error. Please release a new version |
|
Same issue is happening to me, has this issue been solved? |
|
if it happened today then likely no release has been made, include your version here to be sure. |
|
Just checked and the plugin is: disk-usage plugin 0.28 |
|
bump, for releasing .29 or higher |
|
@lvotypko please release a new version of the plugin so everyone can get this fix. |
|
This plugin looks abandoned. Last commit was over a year ago... |
|
I've posted about this on the Jenkinsci-dev mailing list: https://groups.google.com/forum/#!topic/jenkinsci-dev/JO3ONqRlP3o |
11 participants
When display a project,, icons before Job, All bilds, Locked builds, All
workspaces, Slave workspaces, Non-slave workspaces have a broken link.
The root URL was missing, add ${resURL} as prefix in the attribute src,
for node img.