Skip to content

Keep backwards compatibility with old config naming#95

Merged
sarah-witt merged 4 commits into
masterfrom
sarah/maintain-backwards-compat
Jul 21, 2020
Merged

Keep backwards compatibility with old config naming#95
sarah-witt merged 4 commits into
masterfrom
sarah/maintain-backwards-compat

Conversation

@sarah-witt

@sarah-witt sarah-witt commented Jul 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt
sarah-witt marked this pull request as ready for review July 21, 2020 15:47
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Jul 21, 2020
mgarabed
mgarabed suggested changes Jul 21, 2020
View reviewed changes
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
@sarah-witt
sarah-witt merged commit 519dbda into master Jul 21, 2020
@sarah-witt
sarah-witt deleted the sarah/maintain-backwards-compat branch July 21, 2020 20:12
sarah-witt added a commit that referenced this pull request Jul 21, 2020
@sarah-witt
Keep backwards compatibility with old config naming (#95)
8e2361c 
* Keep backwards compatibility

* Fix compat

* remove other vars

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mgarabed mgarabed mgarabed approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarah-witt @mgarabed