Add result tag to stage metrics#92
Conversation
| return 0; | ||
| } | ||
|
|
||
| String getResultTag(@Nonnull FlowNode endNode) { |
There was a problem hiding this comment.
This could potentially live in BuildData and we could check for instance of FlowNode in getResult()
sarah-witt
added
the
changelog/Fixed
| stage('Windows-1'){ | ||
| steps{ | ||
| sh "echo 'Windows 1'" | ||
| exit 1 |
There was a problem hiding this comment.
Why are these steps needed?
There was a problem hiding this comment.
These are needed because the result of this pipeline's stages are inconsistent locally and on the CI. A lot of the stages would fail on the windows images but not the linux images. this makes them fail all the time. There's probably a better way to make the result consistent such as spying that I could look into.
There was a problem hiding this comment.
Oh the "sh" step does not exist on windows right?
I think we should be able to replace all sh "echo XX" by simply echo XX which should be cross platform
| BufferedReader br = new BufferedReader(run.getLogReader()); | ||
| String s; | ||
| while ((s = br.readLine()) != null) { | ||
| System.out.println(s); |
| "jenkins_url:" + DatadogUtilities.getJenkinsUrl(), | ||
| "user_id:anonymous", | ||
| "job:pipelineIntegrationSuccess", | ||
| "result:UNKNOWN", |
There was a problem hiding this comment.
This should be SUCCESS right?
| stage('Windows-1'){ | ||
| steps{ | ||
| sh "echo 'Windows 1'" | ||
| exit 1 |
There was a problem hiding this comment.
Oh the "sh" step does not exist on windows right?
I think we should be able to replace all sh "echo XX" by simply echo XX which should be cross platform
3 participants
Requirements for Contributing to this repository
What does this PR do?
Add result tag to stage metrics
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.