Skip to content

Don't fail validation if log connection is broken#82

Merged
sarah-witt merged 2 commits into
masterfrom
sarah/dont-fail-validation-log
Jul 6, 2020
Merged

Don't fail validation if log connection is broken#82
sarah-witt merged 2 commits into
masterfrom
sarah/dont-fail-validation-log

Conversation

@sarah-witt

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

't fail validation if log connection is broken
@sarah-witt
sarah-witt marked this pull request as ready for review June 25, 2020 13:57
hithwen
hithwen previously approved these changes Jun 25, 2020
@FlorianVeaux

Copy link
Copy Markdown
Contributor

Let's fix conflicts then g2g 👍

@sarah-witt
sarah-witt merged commit 7b0869b into master Jul 6, 2020
@sarah-witt
sarah-witt deleted the sarah/dont-fail-validation-log branch July 6, 2020 13:53
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants