Add workflow-job dependency#72
Merged
Merged
Conversation
sarah-witt
reviewed
Jun 10, 2020
sarah-witt
approved these changes
Jun 10, 2020
Contributor
Author
|
Updated docs as well |
sarah-witt
approved these changes
Jun 15, 2020
FlorianVeaux
added a commit
that referenced
this pull request
Jun 17, 2020
* Add workflow-job dependency * Update version * Reuse jenkins.version constant * Bumpt to 2.164.x * Set min version to 2.164.1
FlorianVeaux
added a commit
that referenced
this pull request
Jun 18, 2020
* Add workflow-job dependency (#72) * Add workflow-job dependency * Update version * Reuse jenkins.version constant * Bumpt to 2.164.x * Set min version to 2.164.1 * Make ClientFactory mockable * Add workflow-job dependency * Update version * Reuse jenkins.version constant * Bumpt to 2.164.x * Collect pipeline logs * Set min version to 2.164.1 * Remove Serializable (it already is) * Add tests * Fix tests * Remove debug logging * Address review * Update src/test/java/org/datadog/jenkins/plugins/datadog/logs/LogCollectionTest.java Co-authored-by: Sarah Witt <[email protected]> Co-authored-by: Sarah Witt <[email protected]>
FlorianVeaux
added
the
changelog/Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Target of this PR is the "pipeline" branch, not master.
This PR adds the jenkins BOM to make management of dependencies easier. It also adds a dependency to workflow-job and bumps the minimum jenkins version.
The jenkins version specified here is the minimum that supports TaskListenerDecorator that will be used in a future PR.