Add minimum jenkins version#67
Merged
Merged
Conversation
sarah-witt
marked this pull request as ready for review
June 8, 2020 19:25
FlorianVeaux
requested changes
Jun 9, 2020
FlorianVeaux
left a comment
FlorianVeaux
left a comment
Contributor
There was a problem hiding this comment.
The plugin is still compatible up to 1.632. Before that, the code doesn't compile because of that method that was not yet introduced.
|
|
||
| <properties> | ||
| <java.level>8</java.level> | ||
| <jenkins.version>2.60.1</jenkins.version> |
Contributor
There was a problem hiding this comment.
Suggested change
| <jenkins.version>2.60.1</jenkins.version> | |
| <jenkins.version>1.632</jenkins.version> |
| ### Installation | ||
|
|
||
| _This plugin requires [Jenkins 1.580.1][2] or newer._ | ||
| _This plugin requires [Jenkins 2.60.1][2] or newer._ |
Contributor
There was a problem hiding this comment.
Suggested change
| _This plugin requires [Jenkins 2.60.1][2] or newer._ | |
| _This plugin requires Java 8+ and [Jenkins 1.632][2] or newer._ |
Contributor
|
Thanks, this will help removing that warning while the plugin has a really soft constraint on the jenkins version. |
sarah-witt
added
the
changelog/Added
…dog-plugin into sarah/jenkins-min-version
FlorianVeaux
previously approved these changes
Jun 9, 2020
FlorianVeaux
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.