Enforce POST in form validation#61
Merged
Merged
Conversation
sarah-witt
marked this pull request as ready for review
April 28, 2020 14:15
FlorianVeaux
previously approved these changes
May 12, 2020
FlorianVeaux
left a comment
FlorianVeaux
left a comment
Contributor
There was a problem hiding this comment.
2 small nits, looks good
…lConfiguration.java Co-authored-by: Florian Veaux <[email protected]>
…lConfiguration.java Co-authored-by: Florian Veaux <[email protected]>
FlorianVeaux
previously approved these changes
May 12, 2020
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
Contributor
|
@sarah-witt Is that ready to be merged ? Can we rebase first also? I don't think |
Collaborator
Author
|
Sure, I'll update it! |
Collaborator
Author
|
Updated and tested! |
FlorianVeaux
approved these changes
Jun 22, 2020
Contributor
|
|
sarah-witt
added
the
changelog/Fixed
sarah-witt
added a commit
that referenced
this pull request
Jun 22, 2020
* enforce POST in form validation * Update src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Co-authored-by: Florian Veaux <[email protected]> * Update src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Co-authored-by: Florian Veaux <[email protected]> * Use require post Co-authored-by: Florian Veaux <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enforces post requests in form validation.
Additional Notes
Following:
https://www.jenkins.io/doc/developer/security/form-validation/
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.