Update codeowners and small fixes#528
Merged
Merged
Conversation
rodrigo-roca
requested review from
CarlosNietoP,
afontan,
drodriguezhdez,
nikita-tkachenko-datadog,
rodrimendoza and
xinyeji
as code owners
March 23, 2026 12:53
rodrimendoza
previously approved these changes
Mar 23, 2026
rodrigo-roca
commented
Mar 23, 2026
| with: | ||
| java-cache: 'maven' # Optionally enable use of a build dependency cache. Specify 'maven' or 'gradle' as appropriate. | ||
| # java-version: 21 # Optionally specify what version of Java to set up for the build, or remove to use a recent default. | ||
| java-version: 17 |
Collaborator
Author
There was a problem hiding this comment.
It didn't build with Java 21, which is the newest default, so specifying the version here is needed
rodrigo-roca
commented
Mar 24, 2026
|
|
||
| public boolean waitForWebhooks(final int number) throws InterruptedException { | ||
| long timeout = System.currentTimeMillis() + TimeUnit.SECONDS.toMillis(10); | ||
| return waitForWebhooks(number, 30); |
Collaborator
Author
There was a problem hiding this comment.
Increased the default timeout from 10s to 30s Some tests kept flaking because of this
afontan
previously approved these changes
Mar 24, 2026
afontan
approved these changes
Mar 24, 2026
rodrigo-roca
added
the
changelog/Changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update codeowners to include new members