Use get from envvars logic when using old CasC format#524
Merged
afontan merged 2 commits intoOct 2, 2025
Conversation
nikita-tkachenko-datadog
previously approved these changes
Sep 29, 2025
nikita-tkachenko-datadog
left a comment
nikita-tkachenko-datadog
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Would be nice to add a test case covering this to org.datadog.jenkins.plugins.datadog.DatadogGlobalConfigurationAsCodeTest. There's already an example with test-config-legacy.yml, you could reuse it and set some env vars to test that they have higher priority than the YAML.
com.github.stefanbirkner.systemlambda.SystemLambda#withEnvironmentVariable can be used to set an env var in a unit test
Collaborator
Author
|
@nikita-tkachenko-datadog I'll do it! I was considering extracting all the |
…ing null as default
afontan
force-pushed
the
alejandro.fontan/fix-null-port-in-old-CasC-format
branch
from
September 30, 2025 13:17
eb481de to
9607284
Compare
afontan
marked this pull request as ready for review
September 30, 2025 13:33
afontan
requested review from
CarlosNietoP,
drodriguezhdez,
rodrigo-roca,
rodrimendoza and
xinyeji
as code owners
September 30, 2025 13:33
nikita-tkachenko-datadog
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of the Change
DatadogAgentConfiguration.DatadogAgentConfigurationDescriptor.getXXXFromEnvVarsinsideDatadogGlobalConfigurationold codeAlternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.