Implement Go auto-instrumentation for Test Optimization#510
Merged
nikita-tkachenko-datadog merged 10 commits intoMay 5, 2025
Merged
Conversation
Collaborator
|
I do hope you based your changes on #504 :) |
| "orchestrion", "version")); | ||
| orchestrionVersion = orchestrionVersionOutput.split(" ")[1]; // Format: "orchestrion v1.0.2" | ||
| } catch (Exception e) { | ||
| orchestrionVersion = "vlatest"; |
Collaborator
There was a problem hiding this comment.
Let's maybe log the exception with a debug level to aid issue investigations
|
|
||
| private static final String TRACER_VERSION_ENV_VAR = "DD_SET_TRACER_VERSION_GO"; | ||
| private static final String LATEST_TAG = "latest"; | ||
| private static final String ORCHESTRION_LATEST_URL = "https://api.github.com/repos/datadog/orchestrion/releases/latest"; |
Collaborator
There was a problem hiding this comment.
I wonder if we can come up with a fallback for cases when the current shell user is not logged in to GitHub
nikita-tkachenko-datadog
previously approved these changes
May 1, 2025
nikita-tkachenko-datadog
approved these changes
May 5, 2025
nikita-tkachenko-datadog
added
the
changelog/Added
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Description of the Change
GoConfiguratorclass that checks thegoversion installed against the required one forOrchestrionand installs it. It then pins it and updates its dependencies. Finally, it updatesGOFLAGSwith'-toolexec=orchestrion toolexec'and setsDD_TRACER_VERSION_GO.GOto TracerLanguage enum.Goto README and to help-languages.html page.Alternate Designs
Possible Drawbacks
Verification Process
Verified using docker compose setup for manual testing.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.