Skip to content

Fix library checkout test when Controller and Agent have different file systems#505

Merged
nikita-tkachenko-datadog merged 2 commits into
masterfrom
nikita-tkachenko/fix-lib-checkout-test-on-windows
Mar 10, 2025
Merged

Fix library checkout test when Controller and Agent have different file systems#505
nikita-tkachenko-datadog merged 2 commits into
masterfrom
nikita-tkachenko/fix-lib-checkout-test-on-windows

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Fixes the logic that verifies if a Git repo checkout is doing a shared library clone.
Currently the logic might fail with IllegalArgumentException if controller node and agent node are running on different operating systems (e.g. Linux and Windows).

Library checkout happens on controller node, so if Git checkout path and build root path (always on controller) have different file systems, we should just return false, as this cannot possibly be a library checkout.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Mar 10, 2025
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review March 10, 2025 13:39
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 26c9170 into master Mar 10, 2025
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-lib-checkout-test-on-windows branch March 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants