Fix library checkout test when Controller and Agent have different file systems#505
Merged
nikita-tkachenko-datadog merged 2 commits intoMar 10, 2025
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
March 10, 2025 13:39
drodriguezhdez
approved these changes
Mar 10, 2025
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fix-lib-checkout-test-on-windows
branch
March 10, 2025 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Fixes the logic that verifies if a Git repo checkout is doing a shared library clone.
Currently the logic might fail with
IllegalArgumentExceptionif controller node and agent node are running on different operating systems (e.g. Linux and Windows).Library checkout happens on controller node, so if Git checkout path and build root path (always on controller) have different file systems, we should just return
false, as this cannot possibly be a library checkout.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.