Fix freshly-cloned shared library checkout detection#489
Merged
nikita-tkachenko-datadog merged 3 commits intoJan 10, 2025
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
January 8, 2025 16:02
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
Is it possible to add this new case to the current test?
Collaborator
Author
I've added some unit tests that verify the basic logic. It's rather difficult to cover this with proper tests because of the complexity of shared libraries set up (the library has to be checked out from a separate repository, and mocking is problematic too because many of the shared libs plugin classes are not public). |
drodriguezhdez
approved these changes
Jan 10, 2025
Collaborator
Author
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/shared-library-fresh-clone-fix
branch
January 10, 2025 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requirements for Contributing to this repository
What does this PR do?
Fixes the logic that detects whether an SCM checkout is a shared library.
Current logic relies on the checked out folder path to detect shared libraries (there's a subfolder whose name ends with
@libsin this case).However, this does not work if the shared library is configured with a "Fresh clone per build" setting: in this case the folder structure is different, and the logic has to account for that.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.