Skip to content

Do not use commit SHA as branch name#482

Merged
nikita-tkachenko-datadog merged 2 commits into
masterfrom
nikita-tkachenko/ignore-sha-branch-names
Jan 7, 2025
Merged

Do not use commit SHA as branch name#482
nikita-tkachenko-datadog merged 2 commits into
masterfrom
nikita-tkachenko/ignore-sha-branch-names

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Updates logic that extract Git branch name to ignore Git commit SHA values.
Git commit SHA is available in a different tag, using commit SHA as branch name is not correct.
One additional problem is that these SHAs may be overwriting branch values correctly determined on previous pipeline steps.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Dec 18, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog force-pushed the nikita-tkachenko/ignore-sha-branch-names branch from 02eec75 to 6febc15 Compare December 20, 2024 11:24
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review January 2, 2025 15:36
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 80f4544 into master Jan 7, 2025
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/ignore-sha-branch-names branch January 7, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants