Skip to content

Propagate executor number data from step trace to stage trace and pipeline trace#475

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/propagate-pipeline-executor-number
Dec 5, 2024
Merged

Propagate executor number data from step trace to stage trace and pipeline trace#475
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/propagate-pipeline-executor-number

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

EXECUTOR_NUMBER environment variable is only available for specific steps, i.e. in DatadogStepListener.
Executor number has to be propagated from step to its corresponding stage, and from stage to pipeline (only for the first step in the pipeline).

https://datadoghq.atlassian.net/browse/SCV-210

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review December 4, 2024 11:28
@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Dec 4, 2024

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 6c70411 into master Dec 5, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/propagate-pipeline-executor-number branch December 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants