Skip to content

Fix auto-instrumentation to inject tracer into Gradle Launcher instead of Gradle Daemon#474

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/gradle-auto-instrumentation-fix
Dec 5, 2024
Merged

Fix auto-instrumentation to inject tracer into Gradle Launcher instead of Gradle Daemon#474
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/gradle-auto-instrumentation-fix

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Updates Test Visibility auto-instrumentation logic for Gradle so that the Java tracer is injected into the Gradle Launcher instead of the Gradle Daemon: injecting the tracer into the daemon required overwriting its org.gradle.jvmargs system property which cancelled out whatever settings the user specified for the Gradle Daemon JVM (see DataDog/dd-trace-java#8001 for more details).

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 25, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review December 4, 2024 11:28

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 5c75e54 into master Dec 5, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/gradle-auto-instrumentation-fix branch December 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants