Skip to content

Enable traces batching by default#473

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/enable-traces-batching-by-default
Dec 5, 2024
Merged

Enable traces batching by default#473
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/enable-traces-batching-by-default

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Enables sending trace data in batches by default.

Prior to this change trace data batching could be enabled by setting the DD_JENKINS_ENABLE_TRACES_BATCHING env variable to true.
This was done as a precaution in case batched requests did not work as expected.
Now that they are known to work (there is a customer who has enabled batching), we can enable them by default.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Added Added features results into a minor version bump label Nov 21, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review December 4, 2024 11:28

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but I'm wondering if we just could keep the env var with default true

@nikita-tkachenko-datadog

nikita-tkachenko-datadog commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

Change LGTM, but I'm wondering if we just could keep the env var with default true

I guess I'm cutting corners a bit here, but I feel confident enough about batching - there's a customer that already verified that it works. And if we do happen to have a problem, there's the option of downgrading the plugin (which is not ideal, but not much worse than having to change an env var and do a restart).

In the long run the advantage of removing the switch altogether is that the logic is simpler.

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 3020fc6 into master Dec 5, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/enable-traces-batching-by-default branch December 5, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants