Enable traces batching by default#473
Merged
nikita-tkachenko-datadog merged 1 commit intoDec 5, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
December 4, 2024 11:28
drodriguezhdez
approved these changes
Dec 5, 2024
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
Change LGTM, but I'm wondering if we just could keep the env var with default true
Collaborator
Author
I guess I'm cutting corners a bit here, but I feel confident enough about batching - there's a customer that already verified that it works. And if we do happen to have a problem, there's the option of downgrading the plugin (which is not ideal, but not much worse than having to change an env var and do a restart). In the long run the advantage of removing the switch altogether is that the logic is simpler. |
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/enable-traces-batching-by-default
branch
December 5, 2024 12:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Enables sending trace data in batches by default.
Prior to this change trace data batching could be enabled by setting the
DD_JENKINS_ENABLE_TRACES_BATCHINGenv variable totrue.This was done as a precaution in case batched requests did not work as expected.
Now that they are known to work (there is a customer who has enabled batching), we can enable them by default.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.