Add NPE checks for jobs started with scripting#471
Merged
Conversation
nikita-tkachenko-datadog
added
the
changelog/Fixed
nikita-tkachenko-datadog
marked this pull request as ready for review
November 14, 2024 19:19
drodriguezhdez
left a comment
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
Dropped minor comments
| long pauseDurationMillis = 0; | ||
| for (StageNodeExt stage : extRun.getStages()) { | ||
| pauseDurationMillis += stage.getPauseDurationMillis(); | ||
| if (extRun != null){ |
Collaborator
There was a problem hiding this comment.
Should we drop a log if the extRun is null?
Collaborator
Author
There was a problem hiding this comment.
The getRunExtForRun() method that returns it will log Error while getting RunExt along with the exception.
| FlowNode node = nodes.poll(); | ||
| nodes.addAll(node.getParents()); | ||
| for (FlowNode parent : node.getParents()) { | ||
| if (parent != null){ |
Collaborator
There was a problem hiding this comment.
Wow, how a FlowNode parent can be null :O?
Collaborator
Author
There was a problem hiding this comment.
I could not reproduce it locally, but I think it has to do with creating job stages dynamically via scripting.
Collaborator
Author
There was a problem hiding this comment.
This isn't a common situation for sure, maybe not even a "normal" one, as even the code in the Jenkins core starts throwing NPEs.
drodriguezhdez
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Adds guardrails for some NPEs observed in customers' logs.
I could not reproduce the errors, but they're likely caused by pipelines/jobs that are submitted with scripting.
Some of the errors happen inside core Jenkins code, so they had to be caught rather than prevented.
Below are the examples of the 4 exceptions fixed:
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.