Skip to content

Only instrument Maven/Gradle/SBT/Ant when doing tests auto-instrumentation#465

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/fine-grained-tests-auto-instrumentation
Nov 6, 2024
Merged

Only instrument Maven/Gradle/SBT/Ant when doing tests auto-instrumentation#465
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/fine-grained-tests-auto-instrumentation

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Updates tests auto-instrumentation logic for Java.

Rather than instrumenting any Java process with JAVA_TOOL_OPTIONS, the updated logic only instruments Maven, Gradle, SBT and Ant builds.

The reason for not instrumenting anything is that some JVM processes hang and do not exit if the Java tracer is injected in them.
Until this issue is debugged and fixed it is best to err on the side of caution and avoid instrumenting everything in favour of only instrumenting the build systems.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Nov 5, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review November 6, 2024 09:38
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 5184582 into master Nov 6, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/fine-grained-tests-auto-instrumentation branch November 6, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants