Only instrument Maven/Gradle/SBT/Ant when doing tests auto-instrumentation#465
Merged
nikita-tkachenko-datadog merged 1 commit intoNov 6, 2024
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
November 6, 2024 09:38
drodriguezhdez
approved these changes
Nov 6, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fine-grained-tests-auto-instrumentation
branch
November 6, 2024 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Updates tests auto-instrumentation logic for Java.
Rather than instrumenting any Java process with
JAVA_TOOL_OPTIONS, the updated logic only instruments Maven, Gradle, SBT and Ant builds.The reason for not instrumenting anything is that some JVM processes hang and do not exit if the Java tracer is injected in them.
Until this issue is debugged and fixed it is best to err on the side of caution and avoid instrumenting everything in favour of only instrumenting the build systems.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.