Skip to content

Delay sending start event for pipelines#461

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/skip-start-event-for-pipelines
Sep 26, 2024
Merged

Delay sending start event for pipelines#461
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/skip-start-event-for-pipelines

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR changes pipeline tracing logic.

When org.datadog.jenkins.plugins.datadog.listeners.DatadogBuildListener#onStarted listener is invoked for a pipeline, the accurate start time for a pipeline is not known yet, because until the first pipeline step starts its execution the pipeline is considered queued.
The backend relies on pipeline start time being consistent (due to some EVP constraints).
Therefore we have to defer sending the first tracing event for pipelines until their accurate start time is known, which is when the "Start of Pipeline" FlowNode is encountered.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Sep 25, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review September 25, 2024 13:15

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file there are just some minor cosmetic improvements, not really related to the logic change.

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 2d13b18 into master Sep 26, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/skip-start-event-for-pipelines branch September 26, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants