Delay sending start event for pipelines#461
Merged
nikita-tkachenko-datadog merged 1 commit intoSep 26, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
September 25, 2024 13:15
Collaborator
Author
There was a problem hiding this comment.
In this file there are just some minor cosmetic improvements, not really related to the logic change.
drodriguezhdez
approved these changes
Sep 26, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/skip-start-event-for-pipelines
branch
September 26, 2024 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR changes pipeline tracing logic.
When
org.datadog.jenkins.plugins.datadog.listeners.DatadogBuildListener#onStartedlistener is invoked for a pipeline, the accurate start time for a pipeline is not known yet, because until the first pipeline step starts its execution the pipeline is considered queued.The backend relies on pipeline start time being consistent (due to some EVP constraints).
Therefore we have to defer sending the first tracing event for pipelines until their accurate start time is known, which is when the "Start of Pipeline"
FlowNodeis encountered.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.