Add user_id, jenkins_url tag#46
Merged
Merged
Conversation
gzussa
requested review from
bkabrda,
jirikuncar,
nmuesch and
zippolyte
as code owners
February 19, 2020 15:01
…remove branch tag and updated some event messages with more contextual details
gzussa
added
the
changelog/Changed
zippolyte
suggested changes
Feb 24, 2020
Comment on lines
+97
to
+103
| if(!tags.containsKey(name)){ | ||
| values = new HashSet<>(); | ||
| }else{ | ||
| values = tags.get(name); | ||
| } | ||
| values.add(value); | ||
| tags.put(name, values); |
Contributor
There was a problem hiding this comment.
let's have something simpler and more readable like
if(!tags.containsKey(name)){
tags.put(name, new HashSet<>());
}
tags.get(name).add(value);
added 2 commits
February 24, 2020 17:08
zippolyte
approved these changes
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
user_idandjenkins_urltags on data being submitted whenever possible.Also removed the
branchtag since it is an unbounded value hence it has little benefit.However I changed events to have the branch names whenever possible.
Also added other contextual infos on event messages.
Verification Process
See development doc.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.