Remove restriction on possible hosts for Java tracer URL#456
Merged
nikita-tkachenko-datadog merged 2 commits intoSep 23, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
September 23, 2024 15:20
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/java-tracer-url-validation
branch
September 23, 2024 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
When using auto-configuration for Test Visibility for Java, it is possible to use
DATADOG_JENKINS_PLUGIN_TRACER_DISTRIBUTION_URLenvironment variable for specifying custom URL that is used for downloading the Java tracer.Currently it is only possible to specify URLs that point to Maven Central.
There is a customer that wants to use their local artifactory instance for downloading the tracer artifact.
So this PR removes the URL host restriction to allow providing URLs to on-premises artifactory.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.