Implement diagnostic flare#454
Merged
nikita-tkachenko-datadog merged 7 commits intoOct 9, 2024
Merged
Conversation
nikita-tkachenko-datadog
added
the
changelog/Added
nikita-tkachenko-datadog
marked this pull request as ready for review
September 23, 2024 14:19
drodriguezhdez
left a comment
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
Dropped some comments
| } | ||
|
|
||
| try { | ||
| LocalDateTime now = LocalDateTime.now(); |
Collaborator
There was a problem hiding this comment.
Could we do this in UTC instead of Local time always?
Collaborator
Author
There was a problem hiding this comment.
Makes sense, fixed
Comment on lines
+34
to
+36
| if (!name.contains("API_KEY") && !name.contains("APP_KEY")) { | ||
| datadogVariables.put(name, e.getValue()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Instead of not sending them, could we just use **********?
Collaborator
Author
There was a problem hiding this comment.
Great idea! Updated the code
Co-authored-by: Daniel Rodriguez Hernandez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Implements diagnostic flare functionality.
A new Datadog page is added to Manage Jenkins -> Troubleshooting.
In this page there is a button to generate and download a diagnostic flare archive.
The archive contains data that is useful for investigating issues with the plugin.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.