Add jenkins.plugin.withWarning metric#453
Conversation
nikita-tkachenko-datadog
added
the
changelog/Added
6fc5749 to
306f21c
Compare
drodriguezhdez
left a comment
drodriguezhdez
left a comment
There was a problem hiding this comment.
Dropped some comments
| Map<PluginWrapper, List<UpdateSite.Warning>> activePluginWarningsByPlugin = updateSiteWarningsMonitor.getActivePluginWarningsByPlugin(); | ||
| return activePluginWarningsByPlugin.size(); |
There was a problem hiding this comment.
Do we know if this is thread safe?
There was a problem hiding this comment.
I checked the getActivePluginWarningsByPlugin() method's implementation, and the map that it returns is local, so there's no other thread that can reach it.
| <dependency> | ||
| <groupId>org.kohsuke</groupId> | ||
| <artifactId>access-modifier-suppressions</artifactId> | ||
| <version>${access-modifier-checker.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Can this new dependency enters in conflict with other deps from Jenkins?
There was a problem hiding this comment.
The version comes from Jenkins BOM, which is there to ensure that different dependencies that the plugin has are mutually compatible.
As for inter-plugin conflicts, the docs say that each plugin has a dedicated classloader at runtime, so I don't think there'll be any issues.
2 participants
Requirements for Contributing to this repository
What does this PR do?
Adds new metric
jenkins.plugin.withWarningwhich is the count of currently installed plugins that have warnings.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.