Skip to content

Fix branch name detection for multibranch pipelines#452

Merged
nikita-tkachenko-datadog merged 3 commits into
masterfrom
nikita-tkachenko/multibranch-pipelines-branch-name
Sep 20, 2024
Merged

Fix branch name detection for multibranch pipelines#452
nikita-tkachenko-datadog merged 3 commits into
masterfrom
nikita-tkachenko/multibranch-pipelines-branch-name

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Fixes branch detection logic for multibranch pipelines.
When a multibranch pipeline is built, Jenkins checks out detached HEAD for a specific branch, so repositry.getBranch() returns commit SHA instead of the branch name.
The fix is to iterate over the refs in the repository to see if any of them points to the checked out SHA.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Sep 20, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review September 20, 2024 11:47
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit ad7af64 into master Sep 20, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/multibranch-pipelines-branch-name branch September 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants