Fix APM tracer libraries verification#444
Merged
nikita-tkachenko-datadog merged 1 commit intoAug 20, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
August 16, 2024 08:58
sarah-witt
approved these changes
Aug 20, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/add-tracer-config-verification
branch
August 20, 2024 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Updates logic that installs APM tracers for Test Visibility.
Before installing the tracer the instrumentation logic checks if installation has already been performed for a given host/pipeline. Rather than checking the actual files on disk, it looks for in-memory metadata that is "attached" to the pipeline object during the tracer installation. That metadata is checked to see if there's record of installing the tracer on a specific host.
This metadata check may not be enough in some cases, for example if there is workspace cleanup in the pipeline logic.
The improved check also verifies that the tracer library is present on disk before deciding to skip installation.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Verified manually for all 3 affected languages (Java, JS, Python) + covered with existing integration tests.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.