Skip to content

Fix APM tracer libraries verification#444

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/add-tracer-config-verification
Aug 20, 2024
Merged

Fix APM tracer libraries verification#444
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/add-tracer-config-verification

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Updates logic that installs APM tracers for Test Visibility.

Before installing the tracer the instrumentation logic checks if installation has already been performed for a given host/pipeline. Rather than checking the actual files on disk, it looks for in-memory metadata that is "attached" to the pipeline object during the tracer installation. That metadata is checked to see if there's record of installing the tracer on a specific host.

This metadata check may not be enough in some cases, for example if there is workspace cleanup in the pipeline logic.

The improved check also verifies that the tracer library is present on disk before deciding to skip installation.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Verified manually for all 3 affected languages (Java, JS, Python) + covered with existing integration tests.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Aug 16, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog linked an issue Aug 16, 2024 that may be closed by this pull request
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review August 16, 2024 08:58
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit dc96660 into master Aug 20, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/add-tracer-config-verification branch August 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JAVA_TOOL_OPTIONS overwrite when using gradle build

2 participants