Skip to content

Add validation for manually set Git timestamps#443

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/manual-git-dates-validation
Aug 20, 2024
Merged

Add validation for manually set Git timestamps#443
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/manual-git-dates-validation

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Adds validation logic for manually set Git timestamps (DD_GIT_COMMIT_AUTHOR_DATE and DD_GIT_COMMIT_COMMITTER_DATE environment variables).
If the provided dates do not correspond to ISO8601 format, they will be ignored and a warning will be written to the logs.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Unit and integration tests added. Also checked manually.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review August 15, 2024 17:30
@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Aug 16, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit c7ac69a into master Aug 20, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/manual-git-dates-validation branch August 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants