Skip to content

Improve hostname calculation logic#428

Merged
nikita-tkachenko-datadog merged 5 commits into
masterfrom
nikita-tkachenko/hostname-calculation-improvements
May 29, 2024
Merged

Improve hostname calculation logic#428
nikita-tkachenko-datadog merged 5 commits into
masterfrom
nikita-tkachenko/hostname-calculation-improvements

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Improves logic that calculates host names:

  • when determining hostname for a freestyle build, use the Node instance that runs the build as a fallback
  • when determining hostname for a Node, use remote shell command execution as a fallback

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Added Added features results into a minor version bump label May 14, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review May 14, 2024 17:04
drodriguezhdez
drodriguezhdez previously approved these changes May 16, 2024

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 91e4b97 into master May 29, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/hostname-calculation-improvements branch May 29, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants