Fix BuildSpanAction deserialization logic#425
Merged
nikita-tkachenko-datadog merged 1 commit intoMay 6, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
May 3, 2024 21:00
drodriguezhdez
approved these changes
May 6, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fix-build-span-data-serialization
branch
May 6, 2024 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Fixes custom deserialisation logic of the
BuildSpanActionclass.The
versionfield was added to the v1 of the converter erroneously.The data written by the original converter v1 (introduced in the plugin v6.0.2) does not contain
versionfield, so when the updated converter code tries to deserialize this field, it fails.The versioned converters are supposed to be immutable, the code was changed by mistake.
The bug was introduced in PR#387 Implement submitting in-progress pipelines data.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.