Skip to content

Add git-client as a plugin dependency#413

Merged
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/add-git-client
Apr 11, 2024
Merged

Add git-client as a plugin dependency#413
nikita-tkachenko-datadog merged 1 commit into
masterfrom
nikita-tkachenko/add-git-client

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Adds git-client plugin as this plugins's dependency.

The Datadog plugin uses Git Client.
Previously it was available as it was a transitive dependency of some other plugin that DD depended on.
Recently this transitive dependency was removed, which broke the plugin.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Apr 11, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review April 11, 2024 16:03
@nikita-tkachenko-datadog nikita-tkachenko-datadog added this to the 6.1.0 milestone Apr 11, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 2acbcf7 into master Apr 11, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/add-git-client branch April 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting exception NoClassDefFoundError Missing git client dependency

2 participants