Refactor Datadog clients#408
Merged
nikita-tkachenko-datadog merged 3 commits intoSep 11, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
April 30, 2024 08:03
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/datadog-clients-refactoring
branch
from
July 3, 2024 10:01
e3759eb to
e87b5c6
Compare
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/datadog-clients-refactoring
branch
from
August 16, 2024 08:40
e87b5c6 to
f048a44
Compare
sarah-witt
approved these changes
Sep 11, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/datadog-clients-refactoring
branch
September 11, 2024 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Refactors the "client" classes that the plugin uses to interact with Datadog Agent or Datadog backend: the code is simplified, some redundant state is being removed, client singleton instance now lives inside a dedicated holder class (that used to be client factory).
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.