[PINT-287] Changed plugin to Java 11#404
Conversation
rahulkaukuntla
changed the title
rahulkaukuntla
changed the title
…of references to NullPointerException
…tadogBuildListener.java Co-authored-by: Nikita Tkachenko <[email protected]>
Co-authored-by: Nikita Tkachenko <[email protected]>
Co-authored-by: Nikita Tkachenko <[email protected]>
| @@ -1,13 +1,13 @@ | |||
| def comonVersion = "2.356" | |||
| def recentLTS = "2.346.1" | |||
| def comonVersion = "2.362" | |||
There was a problem hiding this comment.
If I understand correctly the original goal of this CI config was to have a testing matrix that would check the plugin with the min and the max version of Jenkins that the plugin supports.
If this is still the intention, then we should change this version to 2.453 (the latest release at the moment, still seems to support Java 11).
While we're at it, we could also fix the "comon" typo (and change it to "common" or even "latestSupported").
Also, the original matrix tested the plugin with two different Java versions: 8 and 11. I think it makes sense to continue doing so. We can change the JDK of the "common version" builds to 17 (as this blog post says, Java 17 is being rapidly adopted to run Jenkins now).
There was a problem hiding this comment.
Changing the latestSupported version to 2.453 requires manual version changes below:
However, including these version bumps causes the build to break for the recentLTS version--as such I decided to only bump up the latestSupported to the max version that could be built without breaking the recentLTS version.
| <jenkins.version>2.361.4</jenkins.version> | ||
| <hpi.compatibleSinceVersion>1.0.0</hpi.compatibleSinceVersion> | ||
| <!-- byte-buddy is needed until we bump to java 11: https://stackoverflow.com/questions/69929229/mockito-shipped-within-spring-boot-fails-to-attach-to-jvm-openjdk-11/72912290#72912290 --> | ||
| <byte-buddy.version>1.12.14</byte-buddy.version> |
There was a problem hiding this comment.
Just noticed this comment saying "byte-buddy is needed until we bump to java 11". Have you looked into whether we can remove it now?
There was a problem hiding this comment.
Yes, I have. Looking at the link in the comment, it seems that user needed to do this fix while using jdk11, so saying that it is needed until java 11 is misleading. I will modify the comment.
nikita-tkachenko-datadog
left a comment
nikita-tkachenko-datadog
left a comment
There was a problem hiding this comment.
Looks good to me. It would be ideal to update the testing matrix to have Java 17 and the latest Jenkins release, but this can be done as a separate task.
This reverts commit 27d5a56.
4 participants
What does this PR do?
Updating plugin to Java 11.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.