Implement submitting in-progress pipelines data#387
Merged
nikita-tkachenko-datadog merged 11 commits intoMar 4, 2024
Conversation
nikita-tkachenko-datadog
added
the
changelog/Added
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/in-progress-pipelines
branch
from
February 2, 2024 09:51
c6c5032 to
50ed31c
Compare
…StartedYet() may be true when onStarted() handled is invoked
nikita-tkachenko-datadog
marked this pull request as ready for review
February 27, 2024 19:05
drodriguezhdez
left a comment
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
I dropped some minor comments, but in general LGTM
Comment on lines
+200
to
+209
| // Set StartTime, EndTime and Duration | ||
| this.startTime = run.getStartTimeInMillis(); | ||
| long durationInMs = run.getDuration(); | ||
| if (durationInMs == 0 && startTime != 0) { | ||
| durationInMs = System.currentTimeMillis() - startTime; | ||
| } | ||
| this.duration = durationInMs; | ||
| if (duration != 0 && startTime != 0) { | ||
| this.endTime = startTime + duration; | ||
| } |
Collaborator
There was a problem hiding this comment.
As we discussed offline, the duration and endTime would be omitted if the pipeline is running in the backend. Could we add a comment here just mentioning this? It might be confusing if you think that the endTime is sent for real purpose when the pipeline is running.
Collaborator
Author
There was a problem hiding this comment.
Added the comment
Comment on lines
+70
to
+72
| Long endTime = buildData.getEndTime(null); | ||
| // there are valid cases where endTime is null (in-progress pipelines), and the backend allows for this | ||
| if (endTime != null) { |
Collaborator
There was a problem hiding this comment.
Could we use the isBuilding boolean instead of endTime to check if the pipeline is running or not?
Collaborator
Author
There was a problem hiding this comment.
Added isBuilding check
Co-authored-by: Daniel Rodriguez Hernandez <[email protected]>
drodriguezhdez
approved these changes
Mar 4, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/in-progress-pipelines
branch
March 4, 2024 13:28
nikita-tkachenko-datadog
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 3a508bf.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.