Apply included/excluded job filters when publishing queue metrics#380
Merged
nikita-tkachenko-datadog merged 5 commits intoFeb 2, 2024
Merged
Conversation
nikita-tkachenko-datadog
marked this pull request as ready for review
January 24, 2024 10:44
nikita-tkachenko-datadog
requested review from
drodriguezhdez
and removed request for
sarah-witt
February 2, 2024 09:55
drodriguezhdez
previously approved these changes
Feb 2, 2024
drodriguezhdez
previously approved these changes
Feb 2, 2024
drodriguezhdez
approved these changes
Feb 2, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/queue-metrics-job-filtering
branch
February 2, 2024 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Updates logic that publishes metrics related to the Jenkins queue.
The plugin config has inputs to specify job names that should be included/excluded from tracking.
The queue monitoring logic is updated to consider these filters when publishing metrics for specific jobs.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Added an integration test.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.