Skip to content

Support declarative Test Visibility configuration in pipeline scripts#375

Merged
nikita-tkachenko-datadog merged 4 commits into
masterfrom
nikita-tkachenko/declarative-tracer-configuration
Jan 5, 2024
Merged

Support declarative Test Visibility configuration in pipeline scripts#375
nikita-tkachenko-datadog merged 4 commits into
masterfrom
nikita-tkachenko/declarative-tracer-configuration

Conversation

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Adds support for configuring Test Visibility in pipeline scripts using datadog step.
A new testVisibility property is added to the step, allowing to use automatic Test Visibility configuration in pipelines that do not support UI config (e.g. multi-branch pipelines found inside organization folders).

Description of the Change

If datadog step is present in the pipeline definition and testVisibility block is configured, DatadogTracerJobProperty property is registered in the job.
Existing code that handles the property does the rest.

Alternate Designs

Possible Drawbacks

Verification Process

Verified manually using a local Jenkins instance.
Integration test added.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Added Added features results into a minor version bump label Jan 4, 2024
@github-actions github-actions Bot added the documentation Documentation related changes label Jan 4, 2024

@jhgilbert jhgilbert left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few suggestions, thank you!

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit ce1920d into master Jan 5, 2024
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/declarative-tracer-configuration branch January 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump documentation Documentation related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants