Add ability to granualarly filter events #364
Conversation
…ties.java Co-authored-by: Sarah Witt <[email protected]>
…lConfiguration.java Co-authored-by: Sarah Witt <[email protected]>
…lConfigurationTest.java Co-authored-by: Sarah Witt <[email protected]>
…lConfiguration.java Co-authored-by: Sarah Witt <[email protected]>
…e string rather than event
… for env variable conflicts
brett0000FF
left a comment
brett0000FF
left a comment
There was a problem hiding this comment.
Looks good! I just left a few minor suggestions.
| docker-compose.yaml | ||
| /.vscode/ |
There was a problem hiding this comment.
Is there any specific reason to explicitly ignore these two files?
There was a problem hiding this comment.
the testing documentation recommends creating a docker-compose.yaml file so excluding it from git will prevent unintentional commits with this file, and vscode is a common editor and is ignored in other projects
|
Looks good overall! |
Co-authored-by: Brett Blue <[email protected]>
…g-plugin into sarah/add-event-filters
@NouemanKHAL Good point, we thought about this but then decided it was better to be able to check the event name before creating the event. What do you think of creating static variable for event name in the classes and that way we can still have the property tied to the class but not need to create an instance first? Also while investigating this I found a bug with the shouldSendEvent logic so I fixed that! |
…GlobalConfiguration/config.jelly Co-authored-by: NouemanKHAL <[email protected]>
|
@sarah-witt Great! And yes making it |
sarah-witt
added
the
changelog/Added
5 participants
What does this PR do?
continuing #353 to support filtering events by event name in addition to filtering by category
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.