Skip to content

Adjust HTTP client configuration and batch HTTP metrics#362

Merged
nikita-tkachenko-datadog merged 3 commits into
masterfrom
nikita-tkachenko/http-client-adjustments
Sep 7, 2023
Merged

Adjust HTTP client configuration and batch HTTP metrics#362
nikita-tkachenko-datadog merged 3 commits into
masterfrom
nikita-tkachenko/http-client-adjustments

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Makes some adjustments and fixes in the HTTP client component:

  • limits the number of parallel connections to any given endpoint (Jetty's default was 64, now it is set to 6 with the possibility of overriding via env vars)
  • fixes retry logic to apply retries if no request is received, e.g. if the remote side closes the connection prematurely
  • adjusts retry settings (initial retry delay is increased, delay random jitter is increased)
  • updates the client to always set User-Agent HTTP header in a centralised manner

Adds logic that allows to send multiple metrics in a single HTTP request.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

… to any endpoint. Set user agent centrally. Adjust retry defaults
@nikita-tkachenko-datadog nikita-tkachenko-datadog added the changelog/Fixed Fixed features results into a bug fix version bump label Sep 4, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review September 4, 2023 13:13
@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title HTTP client configuration adjustments HTTP client configuration adjustments + HTTP metrics batching Sep 4, 2023
return httpClient;
}

private static String getUserAgent() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sarah-witt sarah-witt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit d7ef20e into master Sep 7, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/http-client-adjustments branch September 7, 2023 07:26
@sarah-witt sarah-witt changed the title HTTP client configuration adjustments + HTTP metrics batching Adjust HTTP client configuration and batch HTTP metrics Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants