Skip to content

Fix support for setting environment variables such as GIT_BRANCH when CI visibility is disabled#361

Merged
nikita-tkachenko-datadog merged 4 commits into
masterfrom
nikita-tkachenko/build-data-update-without-ci-vis
Sep 11, 2023
Merged

Fix support for setting environment variables such as GIT_BRANCH when CI visibility is disabled#361
nikita-tkachenko-datadog merged 4 commits into
masterfrom
nikita-tkachenko/build-data-update-without-ci-vis

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nikita-tkachenko-datadog nikita-tkachenko-datadog changed the title Update BuilData with info from pipeline steps even if CI Visibility i… Update BuilData with info from pipeline steps even if CI Visibility is disabled Aug 30, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog marked this pull request as ready for review September 4, 2023 19:18
sarah-witt
sarah-witt previously approved these changes Sep 8, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog merged commit 788cd11 into master Sep 11, 2023
@nikita-tkachenko-datadog
nikita-tkachenko-datadog deleted the nikita-tkachenko/build-data-update-without-ci-vis branch September 11, 2023 13:29
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Oct 4, 2023
@sarah-witt sarah-witt changed the title Update BuilData with info from pipeline steps even if CI Visibility is disabled Fix support for setting environment variables such as BRANCH_TAG when CI visibility is disabled Oct 4, 2023
@sarah-witt sarah-witt changed the title Fix support for setting environment variables such as BRANCH_TAG when CI visibility is disabled Fix support for setting environment variables such as GIT_BRANCH when CI visibility is disabled Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants