Update order of hostname detection logic#360
Merged
Merged
Conversation
sarah-witt
added
the
changelog/Fixed
sarah-witt
marked this pull request as ready for review
August 28, 2023 18:46
nikita-tkachenko-datadog
previously approved these changes
Aug 29, 2023
nikita-tkachenko-datadog
approved these changes
Aug 29, 2023
sarah-witt
added
changelog/no-changelog
sarah-witt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The merge of #346 did not take into account the changes from #345 causing build failures. This PR refactors the getAWSInstanceId to use the new HTTP client
Additionally changes the order of the hostname collection so that the AWS instance param takes precedence over the HOSTNAME variable
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.