Fix support for setting environment variables in pipeline stages#356
Merged
nikita-tkachenko-datadog merged 1 commit intoAug 28, 2023
Merged
Conversation
…ulated during previous pipeline stages as fallback
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/build-data-values-propagation
branch
from
August 24, 2023 11:24
baa9117 to
2ac929e
Compare
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/build-data-values-propagation
branch
August 28, 2023 08:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Update
BuildDatacreation logic: when a new instance is created, a check is made to see whether the associated run already refers to another instance that was created and updated during previous pipeline stages.If there is a previously created instance, it is used to populate Git values in the new instance, in case they are missing.
For instance, if there are environment variables that are set inside a pipeline stage (e.g. Git branch and repo URL that are set during SCM checkout), these variables will only be available during that stage: later stages will not be able to use them.
The fallback mechanism ensures that these variables are propagated whenever a new
BuildDatainstance is created at some later point.This fixes https://datadoghq.atlassian.net/browse/AGENT-10162
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Verified manually using a dockerized Jenkins instance.
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.