Skip to content

Add option to use AWS instance ID as hostname#345

Merged
sarah-witt merged 2 commits into
masterfrom
sarah/aws-instance-id-hostname
Jun 15, 2023
Merged

Add option to use AWS instance ID as hostname#345
sarah-witt merged 2 commits into
masterfrom
sarah/aws-instance-id-hostname

Conversation

@sarah-witt

@sarah-witt sarah-witt commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds option to use AWS instance ID as hostname

Description of the Change

When enabled, the plugin will attempt to use the AWS instance ID as the hostname.

Alternate Designs

Don't add an option, and only call the method when on an AWS host

some drawbacks to this approach are:

  • difficult to detect accurately and when jenkins has migrated hosts
  • not backwards compatible

some benefits to this approach are:

  • closer to the agent behavior
  • less configuration bloat

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt
sarah-witt marked this pull request as ready for review June 2, 2023 17:17
@sarah-witt sarah-witt added the changelog/Added Added features results into a minor version bump label Jun 2, 2023
@sarah-witt
sarah-witt merged commit 9b6d2c2 into master Jun 15, 2023
@sarah-witt
sarah-witt deleted the sarah/aws-instance-id-hostname branch June 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants