Look up hostname from controller environment#340
Merged
sarah-witt merged 1 commit intoMay 25, 2023
Merged
Conversation
This is more portable than /bin/hostname (which can be missing in a container image), and most calls in this plugin don't provide any EnvVars.
6 tasks
jglick
approved these changes
May 10, 2023
jglick
left a comment
Member
There was a problem hiding this comment.
Should work in Kubernetes at least (resolving to pod name).
nikita-tkachenko-datadog
approved these changes
May 11, 2023
sarah-witt
approved these changes
May 15, 2023
Collaborator
|
Thanks again @Vlatombe! We aim to release this soon alongside some other hostname detection logic changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more portable than
/bin/hostname(which can be missing in a container image), and most calls in this plugin don't provide anyEnvVars.Requirements for Contributing to this repository
What does this PR do?
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.