Skip to content

Look up hostname from controller environment#340

Merged
sarah-witt merged 1 commit into
jenkinsci:masterfrom
Vlatombe:look-up-hostname-from-controller-environment
May 25, 2023
Merged

Look up hostname from controller environment#340
sarah-witt merged 1 commit into
jenkinsci:masterfrom
Vlatombe:look-up-hostname-from-controller-environment

Conversation

@Vlatombe

Copy link
Copy Markdown
Member

This is more portable than /bin/hostname (which can be missing in a container image), and most calls in this plugin don't provide any EnvVars.

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

This is more portable than /bin/hostname (which can be missing in a
container image), and most calls in this plugin don't provide any
EnvVars.
@Vlatombe Vlatombe changed the title Look up hostname from controller environment as well. Look up hostname from controller environment May 10, 2023

@jglick jglick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work in Kubernetes at least (resolving to pod name).

@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label May 25, 2023
@sarah-witt

Copy link
Copy Markdown
Collaborator

Thanks again @Vlatombe! We aim to release this soon alongside some other hostname detection logic changes.

@sarah-witt
sarah-witt merged commit 2f17616 into jenkinsci:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants