Webhooks: Move user and parameters to the top level#329
Merged
Conversation
albertvaka
force-pushed
the
albertvaka/top-level-user-and-parameters
branch
from
February 14, 2023 12:13
4decc36 to
a652b8e
Compare
nikita-tkachenko-datadog
approved these changes
Feb 14, 2023
sarah-witt
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Those are now standard fields supported by the intake, so we no longer need to send them as generic tags.
It also sets the user email in one of the two cases where before we were only setting the user name. This might be because we never have the email from that function, but it shouldn't hurt to try to get it.
Additional Notes
Doesn't really change the behavior.