Fix logs not showing in Jenkins when log collection was enabled#327
Merged
Conversation
sarah-witt
approved these changes
Feb 13, 2023
sarah-witt
left a comment
sarah-witt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks so much! I tested this out and it works with the Pipeline stage view plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies the
DatadogOutputStreamby extendingLineTransformationOutputStream.Delegating(which exists for this purpose) instead of the baseLineTransformationOutputStream.This fixes the problem where logs for a job would not show up in Jenkins if they were being sent to Datadog.
Fixes #324
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.