Create spans for webhooks as well#317
Merged
Merged
Conversation
drodriguezhdez
approved these changes
Nov 17, 2022
drodriguezhdez
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. As we discussed offline, it would be nice to have some integration tests for the Webhooks part similar to https://github.com/jenkinsci/datadog-plugin/blob/master/src/test/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogGraphListenerTest.java
Collaborator
Author
|
👍 I'll look at DatadogGraphListenerTest and add tests in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the classes that serialize pipelines to webhooks generate a span id and trace id, similar to the classes that serialize to traces.
Description of the Change
datadog-ci relies on us setting the trace and span ids as env vars, which wasn't working for Agentless (sending webhooks instead of traces). We already have code to set these env vars and they are correctly populated since this uses the same logic we have in the classes that generate traces.
Verification Process
span_idandtrace_id(and that trace_id is the same for all the jobs from a same pipeline).$DD_CUSTOM_TRACE_IDand$DD_CUSTOM_PARENT_IDin a job and check they the trace and span ids from the payloads.Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.