Add the default trace agent port to the config#311
Merged
Conversation
This should make configuration easier and it shouldn't have any side effects because it's not used unless CI Visibility is enabled.
sarah-witt
approved these changes
Oct 27, 2022
Collaborator
Author
|
Is the CI failure unrelated? |
Collaborator
|
Yes, it can be ignored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make configuration easier by providing the default port.
The docs actually say this is the default, but it was not.
This shouldn't have any side effects because the port is not used unless CI Visibility is enabled.