Skip to content

Remove synchronization on ConcurrentHashMaps for CI Visibility traces#299

Merged
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/remove_sync_on_immutable_ops
Aug 9, 2022
Merged

Remove synchronization on ConcurrentHashMaps for CI Visibility traces#299
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/remove_sync_on_immutable_ops

Conversation

@drodriguezhdez

@drodriguezhdez drodriguezhdez commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR removes the synchronization added in the following PRs (#243, #286) for the collections that store information to be used for CI Visibility to send the traces to Datadog.

As the collections are ConcurrentHashMaps, it's should not be needed to add explicit synchronization.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez changed the title Remove sync on ConcurrentHashMaps for CI Visibility Remove synchronization on ConcurrentHashMaps for CI Visibility Aug 9, 2022
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review August 9, 2022 14:12
@drodriguezhdez drodriguezhdez changed the title Remove synchronization on ConcurrentHashMaps for CI Visibility Remove synchronization on ConcurrentHashMaps for CI Visibility traces Aug 9, 2022
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/remove_sync_on_immutable_ops branch from f2bb45c to e78aaf4 Compare August 9, 2022 14:27

@sarah-witt sarah-witt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@drodriguezhdez
drodriguezhdez merged commit bf60d11 into master Aug 9, 2022
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/remove_sync_on_immutable_ops branch August 9, 2022 14:44
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants