Skip to content

[CI Visibility] Add hostname info for events executed in Jenkins workers.#298

Merged
drodriguezhdez merged 3 commits into
masterfrom
drodriguezhdez/jenkins_workers_infra_metrics
Aug 9, 2022
Merged

[CI Visibility] Add hostname info for events executed in Jenkins workers.#298
drodriguezhdez merged 3 commits into
masterfrom
drodriguezhdez/jenkins_workers_infra_metrics

Conversation

@drodriguezhdez

@drodriguezhdez drodriguezhdez commented Aug 5, 2022

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR adds the hostname information to the CI Visibility trace using the _dd.hostname tag for Jenkins workers.

To do so, we read the environment variable DD_CI_HOSTNAME that must have been set in the worker previously. In case that envvar is not present, we set the _dd.hostname to none because we don't want to use the controller hostname (If we don't send hostname, it will be overridden by the DD Agent)

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/jenkins_workers_infra_metrics branch from 824b5f4 to 4589a12 Compare August 5, 2022 12:00
@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Aug 5, 2022
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review August 5, 2022 12:01
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/jenkins_workers_infra_metrics branch 3 times, most recently from 91c34be to cc54f56 Compare August 8, 2022 10:33
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/jenkins_workers_infra_metrics branch from cc54f56 to 8d0af71 Compare August 8, 2022 14:06
Daniel Rodriguez Hernandez added 2 commits August 9, 2022 14:26
@drodriguezhdez
drodriguezhdez merged commit d070cae into master Aug 9, 2022
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/jenkins_workers_infra_metrics branch August 9, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants