[CI Visibility] Add hostname info for events executed in Jenkins workers.#298
Merged
drodriguezhdez merged 3 commits intoAug 9, 2022
Merged
Conversation
drodriguezhdez
force-pushed
the
drodriguezhdez/jenkins_workers_infra_metrics
branch
from
August 5, 2022 12:00
824b5f4 to
4589a12
Compare
drodriguezhdez
marked this pull request as ready for review
August 5, 2022 12:01
drodriguezhdez
force-pushed
the
drodriguezhdez/jenkins_workers_infra_metrics
branch
3 times, most recently
from
August 8, 2022 10:33
91c34be to
cc54f56
Compare
drodriguezhdez
force-pushed
the
drodriguezhdez/jenkins_workers_infra_metrics
branch
from
August 8, 2022 14:06
cc54f56 to
8d0af71
Compare
added 2 commits
August 9, 2022 14:26
sarah-witt
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds the hostname information to the CI Visibility trace using the
_dd.hostnametag for Jenkins workers.To do so, we read the environment variable
DD_CI_HOSTNAMEthat must have been set in the worker previously. In case that envvar is not present, we set the_dd.hostnametononebecause we don't want to use the controller hostname (If we don't send hostname, it will be overridden by the DD Agent)Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.