Tag logs with timestamp, datadog.product and ci.pipeline.name#297
Conversation
albertvaka
changed the title
drodriguezhdez
left a comment
drodriguezhdez
left a comment
There was a problem hiding this comment.
I dropped some comments. Looks good to me in general. It's great the job name logic is not dependent anymore on the collected git info.
sarah-witt
left a comment
sarah-witt
left a comment
There was a problem hiding this comment.
Looks good, I left a few comments. Can you also update the readme with the new tags?
e7b4c0b to
c7373b0
Compare
c7373b0 to
4058787
Compare
b2bb8b4 to
bcfbf83
Compare
There was a problem hiding this comment.
@albertvaka speaking only from the screenshot, this is wrong.
ddsource and ddtags are not supposed to be displayed there. They are extracted to the Source facet and log tags.
I think this was already broken for ddtags, and it's related to unallowed characters. This cannot have whitespace or commas within the values. So either some tag cannot be provided through there or it needs some kind of escaping.
I'm not sure about ddsource maybe renaming it to just source works. Otherwise maybe this is different for public and internal requests.
|
We should look into it but I think this was already broken before this PR. If not feel free to revert. |
|
yes it was already wrong 👍 |
sarah-witt
added
the
changelog/Added
4 participants
What does this PR do?
Adds the
timestamp,datadog.productandci.pipeline.nametags to logs, matching logs produced by other CIs.I changed the way we read the pipeline name so it doesn't require git information, since that's not available when we create the logs
DatadogWriterobject.Verification Process
After sending logs with this patch, the new fields should show up here:
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.